fix(svelte): Track components without <script> tags
#5930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Oct 11, 2022
| expect(preProc.markup).toBeUndefined(); | ||
| expect(preProc.style).toBeUndefined(); | ||
| }); | ||
| describe('script hook', () => { |
There was a problem hiding this comment.
For reviewers: Nothing was changed in the tests within this new describe('script hook') closure. I just added this level because the tests we had previously only test our preprocessor's script hook, while the new tests I added test the markup hook as well as the entire preprocessor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // A case that is not covered by regex-testing HTML is e.g. nested <script> tags but I cannot | ||
| // think of why one would do this in Svelte components. | ||
| // Also, we just want to know if there is a <script> tag in the entire file content; not if | ||
| return /<script(\s+.+)?>.*<\/script>/s.test(content); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
| // A case that is not covered by regex-testing HTML is e.g. nested <script> tags but I cannot | ||
| // think of why one would do this in Svelte components. | ||
| // Also, we just want to know if there is a <script> tag in the entire file content; not if | ||
| return /<script(\s+.+)?>.*<\/script>/s.test(content); |
Check failure
Code scanning / CodeQL
Bad HTML filtering regexp
|
Trying a little different approach at the moment as this regex check is not great |
|
Closing this in favour of a new, more robust approach. See #5923 (To Do section) for more details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in our Svelte component tracking implementation where Svelte components without a
<script>tag were not tracked.It adds a function to the preprocessor's
markuphook that has access to the whole.sveltecomponent file. In this function we check if there is a script tag and in case there is not, we add an empty<script> </script>tag to the code. This will later on be picked up by thescripthook where we inject ourtrackComponentfunction call.Furthermore, this PR adds a few tests to check this new behaviour. It's worth mentioning that I added two "higher level" tests that actually use the Svelte compiler's own
preprocessfunction to which we pass our preprocessor. This gives us a more close to real-use testing scenario.fixes #5923